Skip to content

Send .fullyRead marker when navigating out of the room #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 9, 2025

fixes #4173

The PR uses the same approach used by Android:
element-hq/element-x-android#2687

@Velin92 Velin92 requested a review from a team as a code owner June 9, 2025 08:41
@Velin92 Velin92 requested review from pixlwave and removed request for a team June 9, 2025 08:41
@Velin92 Velin92 changed the title Send .fullyRead marker when leaving the room Send .fullyRead marker when navigating out of the room Jun 9, 2025
@Velin92 Velin92 added the pr-bugfix for bug fix label Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.77%. Comparing base (ef55c27) to head (482226b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4177      +/-   ##
===========================================
+ Coverage    78.73%   78.77%   +0.03%     
===========================================
  Files          830      830              
  Lines        75512    75536      +24     
===========================================
+ Hits         59457    59501      +44     
+ Misses       16055    16035      -20     
Flag Coverage Δ
unittests 71.34% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 force-pushed the mauroromito/fix_for_notification_badge_not_going_away branch from b11cc87 to 482226b Compare June 9, 2025 09:20
@stefanceriu
Copy link
Member

I honestly believe this is the wrong solution, we shouldn't rely on exiting a room for it to be marked properly. What if they background the app and it just dies in the background, your state will still be wrong. So sure, this works sometimes but not enough.

Do you know why reaching the bottom of the timeline doesn't do the right thing?

Am I right in believing that the unread marker should behave similarly to the read receipts, marking the top of the currently read content until the bottom is reached and then become unset? We don't have an api for that, do we?

@Velin92 Velin92 force-pushed the mauroromito/fix_for_notification_badge_not_going_away branch from 482226b to 468508a Compare June 10, 2025 09:32
@Velin92 Velin92 merged commit dc5564f into develop Jun 10, 2025
2 of 4 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_for_notification_badge_not_going_away branch June 10, 2025 09:32
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Own read marker (new) does not get updated when reading the room #2281
2 participants